criteo-cookbooks / ms_dotnet

Chef Cookbook to install Microsoft .NET
Apache License 2.0
17 stars 19 forks source link

.NET 4.7 not being installed, it's failing on map function on a String #74

Closed nadobando closed 7 years ago

nadobando commented 7 years ago
diff --git a/libraries/v4_helper.rb b/libraries/v4_helper.rb
index 6863871..fd0adda 100644
--- a/libraries/v4_helper.rb
+++ b/libraries/v4_helper.rb
@@ -117,9 +117,9 @@ module MSDotNet
     def prerequisite_names
       @prerequisite_names ||= case nt_version
         when 6.1
-          { '4.7' => 'KB4019990-6.1' }
+          { '4.7' => ['KB4019990-6.1'] }
         when 6.2
-          { '4.7' => 'KB4019990-6.2' }
+          { '4.7' => ['KB4019990-6.2'] }
         when 6.3
           prerequisites46 = %w(KB2919442 KB2919355 KB3173424)
           {

this fixes the problem with 4.7

Annih commented 7 years ago

Hello @nadobando, thanks for your feedback.

Could you provide a PR with this patch?

Annih commented 7 years ago

Thanks @nadobando for the report. I made the patch.

nadobando commented 7 years ago

Thank you very match, now I can sync my change on my chef server, sorry I didn't saw the email.