search

crittermike / toogles

A fresher, less annoying interface to YouTube.
http://toogl.es
MIT License
418 stars 56 forks source link

Arguably use of $watch #11

Closed dupuchba closed 9 years ago

dupuchba commented 10 years ago

First of all, nice work guys.

But, I am not quite sure that the use of $watch in list.js is the easiest way to do that as it is a best practice to not call it in controllers. blog post here

What about calling search in the ng-submit function of list.html and then set the location ?

crittermike commented 10 years ago

Yep, you're right, good catch. If anyone has a pull request, feel free, otherwise I'll get to it eventually.

dupuchba commented 10 years ago

I can't see exactly what your $watch is doing. I could try to do it otherwise!

crittermike commented 9 years ago

Closing this because it's old and I'm too lazy to work on it at this point.

dupuchba commented 9 years ago

That's a great answer lol :8ball: