Loading cantaloupe data from upholstery

crkn-rcdr / sapindale

Sapper/Svelte access platform administration interface

2 stars 2 forks source link

Loading cantaloupe data from upholstery #28

Closed DivyaKrishnan26 closed 4 years ago

DivyaKrishnan26 commented 4 years ago

Task 91; Able to load the Canvas images from Upholstery, revamp of couchJS functions.

SaschaAdler commented 4 years ago

A couple of layout questions:

Why is the first image not lined up with the rest of them? It sits a bit further to the left.
This might be an advanced feature but can we get a kind of "loading" area for the large image view while we wait for the image to load? The way the image pops into the layout moves a bunch of things around awkwardly.
I'm hoping that the thumbnail view would have its own scrolling area, which means when you scroll down to look at thumbnails you don't need to scroll past the rest of the interface.

SaschaAdler commented 4 years ago

I'd say this all looks fine. When I get a chance I'd like to go through the styles and route structure and see if there are any changes we should make.

I also think we need to close this PR sooner rather than later as it's getting a bit old.

SaschaAdler commented 4 years ago

I think the issue with the current lazy load setup is that since the thumbnails take up no space until the images are loaded, the browser ends up loading all of the images at once. It might make sense to have the container element for the thumbnail take up space beforehand. Set it up with min-width and min-height, perhaps.

SaschaAdler commented 4 years ago

I'm going to merge this, although I think there's some work to do on things. I'll put my thoughts in order about this tomorrow.