crnormand / gurps

Implementing a GURPS 4e game aid for Foundry VTT
MIT License
105 stars 49 forks source link

Feature Request: Tagged Effect Modifiers #2029

Open chrismaille opened 1 week ago

chrismaille commented 1 week ago

Part of improvements suggested on #2013 and #1969

The purpose of this improvement is to add a decision-making logic to the system so that it can automatically add modifiers before rolls.

How do tags work?

Tags are identifications that allow you to cross-reference the "sources" of the rolls with the existing "modifiers":

Where modifiers can be saved?

Usually a third party is the reason for the existence of this modifier, or in other words, the modifier's origin. For example, it can be an advantage, a piece of equipment, a spell, etc. This is where you can optionally save the modifier.

You don't need to find the modifier's origin - it's just a way to organize them. In fact, you can add all your modifiers in Character Sheet's Conditional and/or Reactions sections or inside the Effect Modifiers Popout.

With this in mind, the options for saving modifiers are:

Modifier with tags format

The format is <modifier> <description> <#tag1> <#tag2>...

Example using Foundry Items:

Suppose your Cloth armor (the equipment, or the modifier's origin) gives +3 to all camouflage tests. Opening the armor item, and navigating to "Effects" you can add the armor modifiers here:

image

In the Effect Modifiers popup you will see the modifier created:

image

Now, going to the "Camouflage" skill we add the tags that it should look for before rolling.

image

When requesting a skill roll, the system will search for all modifiers with the tags configured in the skill and add them to the player's Bucket:

GGATaggedRoll

If you have the Show Roll Confirmation Dialog setting enabled, you can check your bucket before rolling. Otherwise, the roll will be made with the selected modifiers.

Example with Actor Components

Suppose you house ruled the "Intuition" trait gives +1 to the "Meditate" skill. On Intuition, you can add the modifier:

image

Then, add the tags the skill "Meditate" will lookup:

image

The Effect Modifiers popup

Use this window to create custom modifiers and to see the list of Actor modifiers. Only the modifiers listed here will be searched for the roll and be added automatically if they have the correct tags.

image

This window shows the following information:

Modifiers with a "custom" origin are those created by the user.

Deleting modifiers

Tags for rolls without items

For rolls that do not have an item or actor component to represent, such as attribute tests (ST, Will, etc.), character tests (vision, fright check, etc.), you can define (or delete) the tags that should be searched for these rolls, in the Foundry settings:

image

About Damage Rolls

This works for damage rolls too, and for large modifiers - ex.: 1d+10 - system will convert the modifier to additional dice, as per GURPS optional rule (B377)

GGATaggedDamage

chrismaille commented 2 days ago

Update (11/21) - Better names

To avoid conflict with Active Effects, some labels have changed:

image