Changes in the API - Githubissues

cronologic-de / xhptdc8_babel

Wrappers, Utilities and Examples for using the xHPTDC8 with various programming languages.

Mozilla Public License 2.0

0 stars 1 forks source link

Closed sulimma closed 3 years ago

sulimma commented 3 years ago

The folling will be removed from the API XHPTDC8_TDC_MODE_GROUPED
XHPTDC8_TDC_MODE_CONTINUOUS xhptdc8_device_configuration.tdc_mode

The following shall be added xhptdc8_grouping_configuration.enabel = false

xhptdc8_device_configuration.tdc_trigger_offset renamed to xhptdc8_device_configuration.thresholds

All defines XHPTDC8_DCOFFSET renamed to XHPTDC8THRESHOLD

Bassem-Ramzy commented 3 years ago

xhptdc8_device_state_to_str() is updated in /lib/include/xHPTDC8_interface.h, with the next commit
bool enabled = false; is added to xhptdc8_grouping_configuration in /lib/include/xHPTDC8_interface.h, with the next commit
All defines XHPTDC8_DCOFFSET renamed to XHPTDC8THRESHOLD updated in /lib/include/xHPTDC8_interface.h, with the next commit
tdc_trigger_offset updated to be thresholds in /lib/include/xHPTDC8_interface.h, with the next commit

sulimma commented 3 years ago

Sorry for chaos, but xhptdc8_device_state_to_str(int state) is correct. Please change it back. The functions without to do not take a parameter.

Bassem-Ramzy commented 3 years ago

Done, and committed

Bassem-Ramzy commented 3 years ago

tdc_mode updates are applied and committed

Bassem-Ramzy commented 3 years ago

All are applied and committed