search

cross-platform-actions / action

Cross-platform GitHub action
MIT License
140 stars 19 forks source link

allow specifiying custom image url #13

Closed epsilon-0 closed 1 year ago

epsilon-0 commented 2 years ago

Signed-off-by: Aisha Tammy floss@bsd.ac

First time working on a github action, so may have made some mistakes. This is in conjunction with the PR to build OpenBSD snapshot images on the openbsd-builder.

jacob-carlborg commented 2 years ago

There needs to be a test. I probably need to create a new repository containing a VM image.

jacob-carlborg commented 2 years ago

Since this is TypeScript, the code needs to be compiled to JavaScript. You need to run npm run all and commit all changed files.

epsilon-0 commented 2 years ago

Addressed all the comments and have updated the PR.

jacob-carlborg commented 2 years ago

Please update the readme and the changelog as well.

epsilon-0 commented 2 years ago

added

jacob-carlborg commented 2 years ago

I've created a new repository for a custom VM image [1]. Could you please add a test for that?

[1] https://github.com/cross-platform-actions/test-custom-image-builder/releases/tag/v1.0.0

jacob-carlborg commented 1 year ago

Merged in: https://github.com/cross-platform-actions/action/commit/12af1e9f176a6e7df6737a58f5eac8bede3adb46.