search

crossfilter / reductio

Reductio: Crossfilter grouping
Other
248 stars 42 forks source link

Create an entry point in reductio API for custom reducers #38

Closed alemarre closed 8 years ago

alemarre commented 8 years ago

Hi,

I have a complex case in my dataset that i can't handle with the native reducers included in reductio. (even if the list is pretty large, thanks for all this work btw)

I suggest to add an entry point for custom reducers in your API, it would allow to plug any custom extension.

Could you please check this pull request ? Don't hesitate to tell me if you see anything wrong :)

Thanks

esjewett commented 8 years ago

Hi,

a) I've been meaning to do this for ages so it's great to get a pull request for this improvement b) It looks good to me at first glance

I'm going to look at it a little more carefully and then I plan to merge it.

However, would you mind updating the documentation in the README as part of this pull request? Just update the README.md file directly.

Thank you! Ethan

alemarre commented 8 years ago

Hi,

I have updated the doc. Thanks for the review

Armand

esjewett commented 8 years ago

Thanks for the contribution! I will try to cut release 0.6.0 today with this functionality.

alemarre commented 8 years ago

Great, thanks for your rapidity !