crossplane-contrib / provider-alibaba

Crossplane provider for Alibaba Cloud

Apache License 2.0

50 stars 18 forks source link

supply alibaba database redis #68

Closed xiqiu618 closed 3 years ago

xiqiu618 commented 3 years ago

Description of your changes

Support provision and management of Alibaba Cloud Database Redis resource.

Fixs:

68

I have:

[x] Read and followed Crossplane's contribution process.
[x] Run make reviewable test to ensure this PR is ready for review.

zzxwill commented 3 years ago

@xiqiu618 I successfully created a Redis instance. Please address those comments and go on with this draft PR.

zzxwill commented 3 years ago

This PR is to implement cloud resource Redis #69.

zzxwill commented 3 years ago

@lowkeyrd Cloud you please help review it? Thanks.

xiqiu618 commented 3 years ago

@negz i am in supply Redis for Alibaba, please help me approve

zzxwill commented 3 years ago

@xiqiu618 Please resolve the conflicts and write more testcases:)

shu-ming commented 3 years ago

when is the expected release date for Redis?

zzxwill commented 3 years ago

when is the expected release date for Redis?

Synced with @xiqiu618 , this feature will be released with this week.

zzxwill commented 3 years ago

@xiqiu618 Closing this PR. All commits are kept in the new one https://github.com/crossplane/provider-alibaba/pull/88.

zzxwill commented 3 years ago

Can anyone help close this PR? The original contributor is so busy with some other stuff, so I took it over to add unit test coverage in a new PR #88 .