Using TARGETARCH to capture arch-appropriate terraform binaries

crossplane-contrib / provider-jet-vault

Generated crossplane provider for vault

Apache License 2.0

6 stars 4 forks source link

Using TARGETARCH to capture arch-appropriate terraform binaries #4

Closed AaronME closed 2 years ago

AaronME commented 2 years ago

Description of your changes

We are seeing errors running builds on Mac M1 machines. Investigating the builds on dockerhub we see that both the arm and amd images are pulling amd binaries.

Setting ARCH Build Arg from TARGETARCH to get proper binaries in each image.

I have:

[X] Read and followed Crossplane's contribution process.
[X] Run make reviewable test to ensure this PR is ready for review.

How has this code been tested

Built locally to confirm the change is non-breaking.

AaronME commented 2 years ago

cc @hasheddan who is more familiar with the build steps here.

AaronME commented 2 years ago

I was under the impression that TARGETARCH was a product of the build submodule. TIL it's a buildx var that the build submodule is manipulating.