Closed zonybob closed 7 months ago
Actually having some issues with make reviewable test
...
panic: load embedded ruleguard rules: rules/rules.go:13: can't load fmt
goroutine 1 [running]:
github.com/go-critic/go-critic/checkers.init.22()
github.com/go-critic/go-critic@v0.6.3/checkers/embedded_rules.go:47 +0x494
16:30:50 [FAIL]
make[2]: *** [go.lint] Error 1
make[1]: *** [lint] Error 2
make: *** [reviewable] Error 2
Will try to get it working...
added resource keycloak_openid_client_client_policy added resource keycloak_openid_client_group_policy added resource keycloak_openid_client_role_policy added resource keycloak_openid_client_user_policy added resource keycloak_openid_client_permissions added resource keycloak_group_permissions added resource keycloak_users_permissions
Description of your changes
Fixes #67 Fixes #68
I have:
make reviewable test
to ensure this PR is ready for review.How has this code been tested
This code was tested by creating and configuring instances of the following resources against a Keycloak 23.0.7 server with fine-grained-authz enabled:
clientclientpolicies.openidclient.keycloak.crossplane.io
clientgrouppolicies.openidclient.keycloak.crossplane.io
clientrolepolicies.openidclient.keycloak.crossplane.io
clientuserpolicies.openidclient.keycloak.crossplane.io
clientpermissions.openidclient.keycloak.crossplane.io
permissions.group.keycloak.crossplane.io
permissions.user.keycloak.crossplane.io
Furthermore a
Role
was created withmanagementPolicies: ["Observe"]
and was imported and deleted successfully (without disturbing the role in keycloak).