crossplane-contrib / provider-upjet-azure

Azure Provider for Crossplane.
https://marketplace.upbound.io/providers/upbound/provider-family-azure/
Apache License 2.0
63 stars 76 forks source link

Feature/add mongo user role resources #859

Open knutejoh opened 3 weeks ago

knutejoh commented 3 weeks ago

Description of your changes

Added resources azurerm_cosmosdb_mongo_role_definition azurerm_cosmosdb_mongo_user_definition

Fixes #858

I have:

How has this code been tested

Test with kind as local cluster provisioning in Azure.

knutejoh commented 3 weeks ago

/test-examples="examples/cosmosdb/v1beta1/mongoroledefinition.yaml"

knutejoh commented 3 weeks ago

/test-examples="examples/cosmosdb/v1beta1/mongoroledefinition.yaml"

knutejoh commented 3 weeks ago

/test-examples="examples/cosmosdb/v1beta1/mongouserdefinition.yaml"

knutejoh commented 3 weeks ago

@turkenf @ulucinar @sergenyalcin @erhancagirici New resource ready for code-review. Note the new func mongoDatabaseBasedId in externalname.go which was needed for extracting the actual ID for these two resources.

turkenf commented 21 hours ago

Hi @knutejoh, thank you for the contribution, could you please rebase your PR to the main and resolve the conflicts to move forward?