search

crossplane / crossplane-runtime

A set of libraries for writing Crossplane controllers.
https://crossplane.io
Apache License 2.0
152 stars 100 forks source link

Indirect github.com/imdario/mergo dependency breaks builds when using crossplane-runtime@v0.19.2 #469

Open kiwansky opened 1 year ago

kiwansky commented 1 year ago

What happened?

We have an indirect dependency on github.com/imdario/mergo via github.com/crossplane/crossplane-runtime. As the version of mergo was raised to v1.0.0 and the module name was changed to dario.cat/mergo it breaks our build now.

I already saw that you updated to dario.cat/mergo@v1.0.0 Please could you release a new version of crossplane/crossplane-runtime with the updated mergo version?

github.com/imdario/mergo: github.com/imdario/mergo@v1.0.0: parsing go.mod: module declares its path as: dario.cat/mergo but was required as: github.com/imdario/mergo

What environment did it happen in?

Crossplane version: v0.19.2 Cloud Provider: IONOS Cloud

kiwansky commented 1 year ago

Currently fixed on our side. Updated webdevops/go-replace to 22.10.0 as it then does not resolve to 1.0.0. Still an update of the library in crossplane would be good.

github-actions[bot] commented 3 weeks ago

Crossplane does not currently have enough maintainers to address every issue and pull request. This issue has been automatically marked as stale because it has had no activity in the last 90 days. It will be closed in 14 days if no further activity occurs. Leaving a comment starting with /fresh will mark this issue as not stale.