NathanFlurry
commented
8 years ago @nbransby I just used some find + replace + a tad of regex magic in Xcode.
As for code styling, I'd highly suggest taking a look at this styling guide. Just some quick feedback from what I saw was generated from crossrails:
- Colons are usually used as
parameterName: Type(notparameterName :Type) for functions, variable definitions, etc.. - Limit your use of
try!in Swift, since you can't catch those error withdo { } catch { }(aka the app will crash entirely if it fails). Either return an optional type if the operation failed or throw/rethrow the error. The same applies for implicitly unwrapped variables, always try to make them optional values if possible. Attempting to access a nil value in an implicitly unwrapped optional will throw an uncatchable error. - File names tend to use upper camel case, e.g.
simpleObject.swiftshould beSimpleObject.swift - Don't do this. Use the
===operator if you're trying to compare the object reference. If your'e trying to compare the object's values, you'll have to implement it manually. - I'd suggest using an
enumfor the message type inSpecialException. It'll make your life easier if you try and localize or create a standardized error code register.
Otherwise, it looks like a very promising project.
Reedyuk
nbransby
Hey thanks Nathan, this is great. I had not had the chance to update to latest beta.
Re the formatting, did you use a formatter in an IDE to do it? Would like to make sure the complier is also outputting best practice formatted Swift.