search

crs4 / hl7apy

Python library to parse, create and handle HL7 v2 messages.
http://crs4.github.io/hl7apy/
MIT License
231 stars 92 forks source link

Improved python 2.6 compatibility #4

Closed TheTechmage closed 5 years ago

TheTechmage commented 10 years ago

We are no longer using dictionary comprehension or set comprehension due to the fact they were both introduced in Python 2.7. A lot of server machines still run CentOS 6 which, in turn, only has Python 2.6 available by default. Please note that people will need to install importlib and possibly some other libraries before hl7apy will work.

svituz commented 10 years ago

First of all, thank you for your collaboration. Currently we support only python 2.7, but we would be glad to extend the support to python 2.6 if you say you use that. I tried to run tests/test_all.py in a CentOS 6 machine with python 2.6 and it fails some tests. Before merging, please change the code to be fully compatible with both versions. Also you should change setup.py to add the dependencies for python 2.6 and change the travis file in order to perform the tests also with the 2.6 version. Finally, I noticed that you branched from master. We use a development model where we branch from the develop branch and then we merge in master only stable releases. So please use develop branch for the modification

TheTechmage commented 10 years ago

Alrighty. I'll make sure I make those changes, branch from develop, and make sure all the tests correctly pass on a nearly fresh install of CentOS. Thanks for the feedback. :smiley:

P.S. Should I update develop since it is 20 commits behind master? (Assuming yes)

svituz commented 10 years ago

Of course get the latest develop version but please don't merge from master, if you mean that. You can avoid that because the commits in master don't include any code modification, if you notice. So you can just pull the last develop version and start coding from that. It's not that beautiful that master is ahead from develop but maybe I will merge from master to develop when we'll release the next version. Thank you and have fun :wink:

svituz commented 5 years ago

Closing since python 2.6 is no more supported