search

crsh / prereg

48 stars 10 forks source link

PRP-QUANT: Update of name + information #19

Closed LisaSpitzerZPID closed 3 years ago

LisaSpitzerZPID commented 3 years ago

Hi Frederik,

I updated the template's name and gave some further information in the yaml header (which resembles the abstract for the template on PsychArchives (http://dx.doi.org/10.23668/psycharchives.4463). Furthermore, I updated two explanatory comments of template items. Hope everything is okay - if not, please feel free to contact me anytime!

Best, Lisa

crsh commented 3 years ago

Hi @LisaSpitzerZPID, this looks great. Just one thing: Could we keep the old function name as an alias and a note that it is deprecated? Otherwise this change will break some previously created documents. Specifically, could you include something like the following in prp_quant_prereg.R?

psyquant_prereg <- function(...) {
  .Deprecated("prp_quant_prereg")
  prp_quant_prereg(...)
}
LisaSpitzerZPID commented 3 years ago

Hi @crsh, thank you for your feedback! I included the code you suggested in the R script. I hope I got it right. Otherwise please feel free to contact me.