search

cruise-automation / daytona

A Vault client, but for containers and servers.
Apache License 2.0
309 stars 33 forks source link

Feature Request: Support VM ScaleSets in Azure #81

Closed mdolton closed 3 years ago

mdolton commented 3 years ago

I would like to be able to login via Daytona from a VM behind a VM ScaleSet in Azure. Currently Daytona tries to retrieve VM metadata from 'Microsoft.Compute/virtualMachines/{instanceName}', but for a VMSS instance it should instead be using 'Microsoft.Compute/virtualMachineScaleSets/{vmScaleSetName}/virtualMachines/{instanceId}'

https://github.com/cruise-automation/daytona/blob/5d44512cd7b64c0054d8e8006bd6ac61e04deb7a/pkg/auth/azure.go#L52