crypto-org-chain / chain-main

Cronos POS Chain⛓: Croeseid Testnet and beyond development
https://cronos-pos.org/
Other
497 stars 352 forks source link

Problem: solomachine and ibc-go are outdated #1089

Closed mmsqe closed 3 weeks ago

mmsqe commented 3 weeks ago

👮🏻👮🏻👮🏻 !!!! REFERENCE THE PROBLEM YOUR ARE SOLVING IN THE PR TITLE AND DESCRIBE YOUR SOLUTION HERE !!!! DO NOT FORGET !!!! 👮🏻👮🏻👮🏻

PR Checklist:

Thank you for your code, it's appreciated! :)

codecov[bot] commented 3 weeks ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 36.61%. Comparing base (69a8c50) to head (355827e). Report is 1 commits behind head on master.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #1089 +/- ## ========================================== + Coverage 34.23% 36.61% +2.38% ========================================== Files 93 101 +8 Lines 14151 14396 +245 ========================================== + Hits 4844 5271 +427 + Misses 8365 8174 -191 - Partials 942 951 +9 ``` | [Flag](https://app.codecov.io/gh/crypto-org-chain/chain-main/pull/1089/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=crypto-org-chain) | Coverage Δ | | |---|---|---| | [integration_tests](https://app.codecov.io/gh/crypto-org-chain/chain-main/pull/1089/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=crypto-org-chain) | `25.70% <ø> (ø)` | | | [integration_tests_byzantine](https://app.codecov.io/gh/crypto-org-chain/chain-main/pull/1089/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=crypto-org-chain) | `11.24% <ø> (ø)` | | | [integration_tests_gov](https://app.codecov.io/gh/crypto-org-chain/chain-main/pull/1089/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=crypto-org-chain) | `11.51% <ø> (ø)` | | | [integration_tests_grpc](https://app.codecov.io/gh/crypto-org-chain/chain-main/pull/1089/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=crypto-org-chain) | `11.51% <ø> (ø)` | | | [integration_tests_ibc](https://app.codecov.io/gh/crypto-org-chain/chain-main/pull/1089/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=crypto-org-chain) | `27.43% <ø> (ø)` | | | [integration_tests_ledger](https://app.codecov.io/gh/crypto-org-chain/chain-main/pull/1089/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=crypto-org-chain) | `11.49% <ø> (ø)` | | | [integration_tests_slow](https://app.codecov.io/gh/crypto-org-chain/chain-main/pull/1089/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=crypto-org-chain) | `11.49% <ø> (ø)` | | | [integration_tests_solomachine](https://app.codecov.io/gh/crypto-org-chain/chain-main/pull/1089/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=crypto-org-chain) | `11.28% <ø> (ø)` | | | [integration_tests_upgrade](https://app.codecov.io/gh/crypto-org-chain/chain-main/pull/1089/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=crypto-org-chain) | `11.51% <ø> (ø)` | | | [unit_tests](https://app.codecov.io/gh/crypto-org-chain/chain-main/pull/1089/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=crypto-org-chain) | `12.01% <ø> (?)` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=crypto-org-chain#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

yihuang commented 3 weeks ago

actually persist-credentials: false should be better practice, and it seems to work too: https://github.com/crypto-org-chain/chain-main/pull/1090