search

crypto-org-chain / cronos

Cronos is the first Ethereum-compatible blockchain network built on Cosmos SDK technology. Cronos aims to massively scale the DeFi, GameFi, and overall Web3 user community by providing builders with the ability to instantly port apps and crypto assets from other chains while benefiting from low transaction fees, high throughput, and fast finality.
Other
296 stars 238 forks source link

Problem: fund_test_accounts is slow with big num_accounts in testground #1551

Closed mmsqe closed 3 months ago

mmsqe commented 3 months ago

👮🏻👮🏻👮🏻 !!!! REFERENCE THE PROBLEM YOUR ARE SOLVING IN THE PR TITLE AND DESCRIBE YOUR SOLUTION HERE !!!! DO NOT FORGET !!!! 👮🏻👮🏻👮🏻

with 81500000 max_gas per block, run gen /tmp/data 8 1 testplan-{index} 2500 5 locally

block 171 3880 2024-08-21T01:15:14.893717251Z
block 172 2841 2024-08-21T01:15:25.09771584Z
block 173 1121 2024-08-21T01:15:40.627708055Z
block 174 3880 2024-08-21T01:15:48.092457461Z
block 175 3880 2024-08-21T01:15:54.452387131Z

PR Checklist:

Thank you for your code, it's appreciated! :)

Summary by CodeRabbit

Summary by CodeRabbit

coderabbitai[bot] commented 3 months ago

Walkthrough

The recent changes significantly enhance the transaction management capabilities of the benchmark toolset by introducing batch processing and improved broadcasting mechanisms. The modifications streamline how transactions are funded and processed, improving efficiency and adaptability. Key updates include new functions for building and broadcasting batch transactions, along with adjustments to existing functions to accommodate these enhancements, ultimately improving overall functionality and network reliability.

Changes

Files Change Summary
testground/benchmark/benchmark/sendtx.py
testground/benchmark/benchmark/stateless.py		 Updated fund_test_accounts to accept an additional cli parameter and handle transactions in batches using build_batch_tx and broadcast_tx_json. Modified run to include output="json" and increased wait_for_peers timeout from 600 to 2400 seconds.
testground/benchmark/benchmark/peer.py Added a new "db_backend": "rocksdb" entry to the config_patch dictionary in patch_configs, enhancing configuration management without altering existing functionality.
testground/benchmark/benchmark/utils.py Introduced build_batch_tx and broadcast_tx_json functions for batch transaction handling and broadcasting capabilities.
integration_tests/cosmoscli.py Modified event_query_tx_for method to include a new timeout parameter, allowing callers to specify how long to wait for transaction event processing.

Poem

In the land of code where rabbits play,
New features hop forth, brightening the day.
Batch transactions now dance in a line,
Broadcasting joy, making workflows divine!
With each little change, we leap and we cheer,
For the magic of coding brings us all near! 🐇✨

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share - [X](https://twitter.com/intent/tweet?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A&url=https%3A//coderabbit.ai) - [Mastodon](https://mastodon.social/share?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A%20https%3A%2F%2Fcoderabbit.ai) - [Reddit](https://www.reddit.com/submit?title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&text=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code.%20Check%20it%20out%3A%20https%3A//coderabbit.ai) - [LinkedIn](https://www.linkedin.com/sharing/share-offsite/?url=https%3A%2F%2Fcoderabbit.ai&mini=true&title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&summary=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code)
Tips ### Chat There are 3 ways to chat with [CodeRabbit](https://coderabbit.ai): - Review comments: Directly reply to a review comment made by CodeRabbit. Example: - `I pushed a fix in commit .` - `Generate unit testing code for this file.` - `Open a follow-up GitHub issue for this discussion.` - Files and specific lines of code (under the "Files changed" tab): Tag `@coderabbitai` in a new review comment at the desired location with your query. Examples: - `@coderabbitai generate unit testing code for this file.` - `@coderabbitai modularize this function.` - PR comments: Tag `@coderabbitai` in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples: - `@coderabbitai generate interesting stats about this repository and render them as a table.` - `@coderabbitai show all the console.log statements in this repository.` - `@coderabbitai read src/utils.ts and generate unit testing code.` - `@coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.` - `@coderabbitai help me debug CodeRabbit configuration file.` Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. ### CodeRabbit Commands (invoked as PR comments) - `@coderabbitai pause` to pause the reviews on a PR. - `@coderabbitai resume` to resume the paused reviews. - `@coderabbitai review` to trigger an incremental review. This is useful when automatic reviews are disabled for the repository. - `@coderabbitai full review` to do a full review from scratch and review all the files again. - `@coderabbitai summary` to regenerate the summary of the PR. - `@coderabbitai resolve` resolve all the CodeRabbit review comments. - `@coderabbitai configuration` to show the current CodeRabbit configuration for the repository. - `@coderabbitai help` to get help. Additionally, you can add `@coderabbitai ignore` anywhere in the PR description to prevent this PR from being reviewed. ### CodeRabbit Configuration File (`.coderabbit.yaml`) - You can programmatically configure CodeRabbit by adding a `.coderabbit.yaml` file to the root of your repository. - Please see the [configuration documentation](https://docs.coderabbit.ai/guides/configure-coderabbit) for more information. - If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: `# yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json` ### Documentation and Community - Visit our [Documentation](https://coderabbit.ai/docs) for detailed information on how to use CodeRabbit. - Join our [Discord Community](https://discord.com/invite/GsXnASn26c) to get help, request features, and share feedback. - Follow us on [X/Twitter](https://twitter.com/coderabbitai) for updates and announcements.
codecov[bot] commented 3 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 15.24%. Comparing base (f3509d7) to head (09bbf1f). Report is 1 commits behind head on main.

:exclamation: There is a different number of reports uploaded between BASE (f3509d7) and HEAD (09bbf1f). Click for more details.

HEAD has 12 uploads less than BASE | Flag | BASE (f3509d7) | HEAD (09bbf1f) | |------|------|------| ||2|0| |integration_tests|20|10|
Additional details and impacted files [![Impacted file tree graph](https://app.codecov.io/gh/crypto-org-chain/cronos/pull/1551/graphs/tree.svg?width=650&height=150&src=pr&token=92w0Dz1Coj&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=crypto-org-chain)](https://app.codecov.io/gh/crypto-org-chain/cronos/pull/1551?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=crypto-org-chain) ```diff @@ Coverage Diff @@ ## main #1551 +/- ## =========================================== - Coverage 36.12% 15.24% -20.89% =========================================== Files 97 67 -30 Lines 7725 4874 -2851 =========================================== - Hits 2791 743 -2048 + Misses 4585 4037 -548 + Partials 349 94 -255 ``` [see 47 files with indirect coverage changes](https://app.codecov.io/gh/crypto-org-chain/cronos/pull/1551/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=crypto-org-chain)