search

cryptomator / cryptofs

Java Filesystem Provider with integrated encryption
GNU Affero General Public License v3.0
93 stars 35 forks source link

fix `CryptoBasicFileAttributes` #GH-141 #140

Closed revintec closed 2 years ago

revintec commented 2 years ago

the old implementation returns wrong file size for symbolic links, e.g. file symlink after ln -s . symlink should be 1

CLAassistant commented 2 years ago

CLA assistant check
All committers have signed the CLA.

overheadhunter commented 2 years ago

Hi, can you please:

  1. Create a bug report claiming that symlink size is incorrect and provide some official source documenting what the correct size of a symlink should be like? E.g. man stat:

    The st_size field gives the size of the file (if it is a regular file or a symbolic link) in bytes. The size of a symbolic link is the length of the pathname it contains, without a terminating null byte.

  2. When "fixing" the symlink size, please don't break the directory size 😉
overheadhunter commented 2 years ago

Thank you very much!