search

cryspen / atlas

BMBF ATLAS project
https://cryspen.com/atlas/
4 stars 0 forks source link

Jonas/refactor tables #40

Closed jschneider-bensch closed 11 months ago

jschneider-bensch commented 11 months ago

This PR greatly simplifies table data structures and thereby table transformations.

It's still a draft for now since the WASM demo needs more help. It's updated to use the new table types but the wasm feature does not build at the moment, I believe because of the dependency on libcrux, although I tried enabling libcrux'es own wasm feature, to no avail.

franziskuskiefer commented 11 months ago

What's the state here?

jschneider-bensch commented 11 months ago

The demo can be built now, since I pinned libcrux to an earlier commit, by using the emscripten toolchain, i.e.

$ cd ./hacspec-scrambledb/scrambledb
$ CC=emcc AR=emar wasm-pack build --target web --features wasm

builds the demo in hacspec-scrambledb/scrambledb/pkg. I think the main part of the PR (the tables) are for sure ready for review and tidying up the demo build could be addressed in a follow-up.

jschneider-bensch commented 11 months ago

With the latest commit, I've removed the old comments, aligned the transformation names with the naming scheme from the spec and given more consistent doc comments.