search

crystal-community / jwt

JWT implementation in Crystal
MIT License
206 stars 24 forks source link

Use OpenSSL::Digest#final #32

Closed bcardiff closed 4 years ago

bcardiff commented 4 years ago

This are the changes need to upgrade to Crystal 0.35

Related to changes in shards 0.11 I recommend adding a crystal property in the shard.yml to state which crystal version are expected to be used with this shard.

If compatibility with older versions is wanted {% if compare_versions(Crystal::VERSION, "0.35.0-0") >= 0 %} can be used.

Both dependencies should be updated also

stakach commented 4 years ago

Thanks for your help here! New shard cut v1.4.2

bcardiff commented 4 years ago

Hi @stakach glad to help :-)

I noticed that 1.4.2 is released yet it is changing which is the compatibility crystal version, dropping support for 0.34.

Doing that kind of upgrades in patch releases can cause some headaches to users. https://github.com/luckyframework/lucky_cli/pull/516

As a rule of thumb, when the change is not backward compatible a breacking-change release should be done. On 0.x, 0.x+1 will do. On 1.x I think a 2.0 should be done. That is, if we honor semver.

Maybe I should have included {% if compare_versions(Crystal::VERSION, "0.35.0-0") >= 0 %} changes initially. But I wasn't sure the commitment wanted for this shard.

stakach commented 4 years ago

good point.. I'll be sure to do this next time I could yank that version and up to v2 now but probably also have to do that for bindata and openssl too :(