search

cs50 / help50-deprecated

This is help50, a command-line tool that helps students understand error messages.
https://cs50.harvard.edu/
GNU General Public License v3.0
62 stars 64 forks source link

Remove Pexpect #281

Closed ashenm closed 4 years ago

ashenm commented 4 years ago

Resolves #275 and constricts Windows support disjunction

kzidane commented 4 years ago

Thank you!!

The reason why pexpect is used is to trick the process into thinking that it's running in a terminal to preserve things like colored output. Also for interactive commands, using subprocess.run or subprocess.check_output wouldn't suffice because we need to show the command's output in real time. I tried removing pexpect per https://github.com/cs50/help50/pull/282, so that version of help50 should work on Windows now although colors outputted by the command probably won't work.