search

cs96and / FoundryVTT-damage-log

FoundryVTT module to report all damage and healing to a separate chat tab
MIT License
9 stars 9 forks source link

Damage not being sent to separate chat tab #10

Closed BronzeToad closed 2 years ago

BronzeToad commented 3 years ago

Foundry VTT v0.8.9

The radio button "Use separate damage log tab" does not appear to be working. Damage log output is still being sent to regular chat tab.

Screen Shot 2021-09-18 at 9 30 17 PM

Screen Shot 2021-09-18 at 9 30 30 PM

cs96and commented 3 years ago

Which version of Damage log?

Do you have any other modules enabled? If so, can you try with just damage log enabled?

cs96and commented 3 years ago

Also I notice that the message is not green or red, so the CSS is not being proper applied here.

Are there any errors in the console?

rmasoni commented 3 years ago

I had the same thing while testing it after I first installed the module, but when I used it in the actual session, it worked correctly. Not really sure what caused it to appear on the main chat. I'll report back if I find a way to reproduce the issue.

BronzeToad commented 3 years ago

I'm not sure what I was on, whatever latest was when I opened the issue. I just updated to 1.5.2 and it's still present.

I launched in safe-mode (disable all modules, stops all playlists, deactivates scenes), turned on combat tracker and libwrapper, and the issue is still present.

I did notice that it was intermittent during my session Sunday afternoon, but when testing solo it's consistently being sent to the normal chat tab.

rmasoni commented 3 years ago

That might be it. I had the issue when I was the only one logged in.

cs96and commented 3 years ago

When a message gets sent to the wrong tab, are there any errors in the console?

rmasoni commented 2 years ago

I haven't been able to reproduce this yet. I'll try again later and keep an eye on the console.

BronzeToad commented 2 years ago

I'll check the console this evening, I haven't been in there for the last few days.

cs96and commented 2 years ago

Our of interest, which system are you using?

rmasoni commented 2 years ago

It's D&D 5e for me.

meldogs commented 2 years ago

I ran into this error too. Foundry 0.8.9, PF2E 2.14.1.8153, and Damage Log 1.5.2 Damage Log Error

Chat Log .

cs96and commented 2 years ago

Out of interest what browser are you using? I have a feeling I may be using some feature of JavsScript that is not supported in all browsers

meldogs commented 2 years ago

Chrome Version 94.0.4606.61 (Official Build) (64-bit) I was just going to post that when I logged out and then back into the world everything looked normal. I applied the damage from the previous attack again and it worked properly. Chat Log 2 Damage Log 2

meldogs commented 2 years ago

I found out one more thing. The error comes back when you clear the chat log. I deleted everything in the chat log and made the attack/applied the damage and the error returned. I don't know if that is useful information but I thought I would let you know just in case. Also, there are actually four errors that get created. I only included one in the first capture because they looked to be the same but this one has all four in case that is important. Love the mod and thanks for your help. Damage Log Error 2

BronzeToad commented 2 years ago

Appreciate others stepping in as I haven't had time to troubleshoot. Thanks!

@meldogs - what modules are you using to get that output? Feel free to message me on discord (BronzeToad#2551) to keep this chat clear for @cs96and.

cs96and commented 2 years ago

I found out one more thing. The error comes back when you clear the chat log. I deleted everything in the chat log and made the attack/applied the damage and the error returned. I don't know if that is useful information but I thought I would let you know just in case. Also, there are actually four errors that get created. I only included one in the first capture because they looked to be the same but this one has all four in case that is important. Love the mod and thanks for your help. Damage Log Error 2

How are you applying the damage? Are you just modifying the HP directly in the token? Or does PF2 have apply damage buttons that you are using?

meldogs commented 2 years ago

How are you applying the damage? Are you just modifying the HP directly in the token? Or does PF2 have apply damage buttons that you are using?

PF2E has a button for applying damage / healing. Apply Damage .

meldogs commented 2 years ago

FYI - I tried modifying the HP directly from the token just now and that works properly. Sorry, I should have tried that before sending the last message.

cs96and commented 2 years ago

3ed8fffc4e6c102c369a51ab1ea82ae6cd2dc37e 2c55acc44f665c4f93523f13b2b17a5f1d0a77db

cs96and commented 2 years ago

This should now be fixed in 1.5.3

rmasoni commented 2 years ago

Just want to let you know that I on DnD5e did not use the apply damage buttons. I applied the damage directly.

cs96and commented 2 years ago

Just want to let you know that I on DnD5e did not use the apply damage buttons. I applied the damage directly.

Can you check that 1.5.3 fixes the issue for you please?

BronzeToad commented 2 years ago

Confirmed resolved with 1.5.3