search

csg-org / esb-data-standard

EAVS Section B Data Standard
https://eavs-section-b-data-standard.readthedocs.io/en/latest/
2 stars 1 forks source link

VoterType without VoterOtherType #13

Closed JDziurlaj closed 5 years ago

JDziurlaj commented 5 years ago

VoterType has an enumeration literal other, which would imply there should be a VoterOtherType field, but there isn't. This is not to say there needs to be one, but to clarify the intent here.

jungshadow commented 5 years ago

Fair point on consistency. I guess I wasn't comfortable with adding another field unless we really knew there really was some other VoterType. Incidentally, it did show up once, but that was because a state included all their regular absentee voters. I'm ok with adding VoterOtherType, but maybe we should remove the other enumeration value. What do you think?

JDziurlaj commented 5 years ago

I'd say remove the other enumeration literal, the values there are already pretty comprehensive.