Refactoring for Tableschema

csg-org / esb-data-standard

EAVS Section B Data Standard

2 stars 1 forks source link

Closed JDziurlaj closed 4 years ago

JDziurlaj commented 4 years ago

The datapackage remains temporarily (until we can verify that we no longer need it)

jungshadow commented 4 years ago

@JDziurlaj Looks good to me and feel free to merge when ready. Made me think of a couple of things:

Should we have a default/recommended linter/formatter/validator set up in our coding environments (or as a pre-commit hook)?
Should we mark the datapackage as deprecated?

I don't think these are holdups for the merge. Just thinking aloud. I'll open them up as their own issues for discussion.

JDziurlaj commented 4 years ago

I think at least one of our tools still expects a datapackage (maybe the SQLite importer?) But yes, I think depreciation makes sense.