search

csgillespie / efficientR

Efficient R programming: a book
https://csgillespie.github.io/efficientR/
Other
721 stars 375 forks source link

reformat spacing #225

Closed mrchypark closed 7 years ago

Robinlovelace commented 7 years ago

Looks good to me - makes the prose more consistent and tidy.

FYI we're deliberately doing per-sentence line breaks for the geocompr book project in the drafting stage because it makes reading diffs and moving sentences around.

mrchypark commented 7 years ago

you means

This chapter introduces the book. It describes the wide range of people it was written for, in terms of R and programming experience, and how you can get the most out of it.

is prefer than

This chapter introduces the book. It describes the wide range of people it was written for, in terms of R and programming experience, and how you can get the most out of it.

is that correct?

Robinlovelace commented 7 years ago

No I don't mean that - your change looks good.

mrchypark commented 7 years ago

I don't understand sentence "we're deliberately doing per-sentence line breaks".

Robinlovelace commented 7 years ago

I mean that in a different repo we're using one sentence per line, like this:

Sentence one.
Sentence two.

But in this repo we're using a style with one paragraph per line, like this:

Sentence one. Sentence two. 

Paragraph two.

I think your changes adhere to the style used in this repo.

mrchypark commented 7 years ago

Oh, understand. Thank you for explain to me.