csiro-coasts / emsarray

xarray extension that supports EMS model formats
BSD 3-Clause "New" or "Revised" License
13 stars 2 forks source link

Consolidate depth coordinate methods #143

Closed mx-moth closed 2 months ago

mx-moth commented 2 months ago

As per #140, there are far too many methods that deal with depth coordinates. Since #142 it is possible to use either a variable or its name interchangeably in most methods, making one of Convention.depth_coordinate or Convention.get_depth_name() et al superfluous. This PR drops Convention.get_depth_name() and similar methods in preference of using the coordinate variables directly.

Closes https://github.com/csiro-coasts/emsarray/issues/138, https://github.com/csiro-coasts/emsarray/issues/140