search

css / csso-cli

Command line interface for CSSO
MIT License
133 stars 10 forks source link

Fix Windows sourcemap paths. #12

Closed XhmikosR closed 5 years ago

XhmikosR commented 5 years ago

Refs #7.

/CC @lahmatiy

XhmikosR commented 5 years ago

Ping @lahmatiy. There's also https://github.com/twbs/bootstrap/pull/27811#discussion_r241160546

lahmatiy commented 5 years ago

Sorry for delay with response. I fixed problem by myself since it has one more issue to fix (see d162d065a8240dd3c146a8c23c0e89c2ff898ba1). Thank you!

XhmikosR commented 5 years ago

NP, I'll test it out in the next release :)

lahmatiy commented 5 years ago

Published as 2.0.1 (https://github.com/css/csso-cli/releases/tag/v2.0.1)

XhmikosR commented 5 years ago

@lahmatiy: the slashes issue is fixed. But I still see another issue in Bootstrap, see my comment https://github.com/twbs/bootstrap/pull/27811#discussion_r241160546

XhmikosR commented 5 years ago

Maybe it's not a bug, I don't know, but I couldn't get your attention in the PR.

lahmatiy commented 5 years ago

@XhmikosR Sorry, I thought the PR is about paths issue, therefore I did not look deeper. Will take a look!

XhmikosR commented 5 years ago

@lahmatiy: NP, and thanks for taking a look. BTW I was wondering, why doesn't csso expose the source map API so that we don't reinvent the wheel here?