iPad plugin fail to extract extension if URL has . in query string

[GoogleCodeExporter]

In flowplayer.ipad.js, trunk,

240: extendedClip.extension = 
extendedClip.completeUrl.substr(extendedClip.completeUrl.lastIndexOf('.'));

extension will be extracted incorrectly if completeUrl has . (dot) in query 
string.

Original issue reported on code.google.com by iwatth on 16 Aug 2011 at 10:05

[GoogleCodeExporter]

Here's my fix.

Original comment by iwatth on 16 Aug 2011 at 10:13

Attachments:

• fixquery.patch

[GoogleCodeExporter]

Thank you. But have you actually tried your proposal?

x = 'test.mp4?test=hello';
queryIndex = x.indexOf('?');
x.substr(x.lastIndexOf('.' , queryIndex));
".mp4?test=hello"

This seems to work better:

x = 'test.mp4?test=hello';
queryIndex = x.indexOf('?');
if (queryIndex > -1) x = x.substr(0, queryIndex);
x.substr(x.lastIndexOf('.'))
".mp4"

Original comment by blacktrashproduct on 5 Jun 2012 at 10:51

• Changed state: Accepted

[GoogleCodeExporter]

Well, I think my code was difference than the one I'm using. Thanks
for correction.

Original comment by iwatth on 5 Jun 2012 at 11:08

[GoogleCodeExporter]

Fixed in http://code.google.com/p/flowplayer-plugins/source/detail?r=1911

Original comment by blacktrashproduct on 5 Jun 2012 at 11:11

• Changed state: Fixed