cssinjs / jss

JSS is an authoring tool for CSS which uses JavaScript as a host language.
https://cssinjs.org
MIT License
7.08k stars 399 forks source link

Question: peer dependency or dependency when installed in a library #1481

Closed sag1v closed 3 years ago

sag1v commented 3 years ago

My question is more related to styled-jss but i guess it depends on JSS implementation.

When we use JSS inside a library/package, should we install it as peerDependencies or regular dependencies?

Is there something to watch out for, regarding multiple instances or versions conflict when a library use jss / styled-jss as well as the consumer?

kof commented 3 years ago

Here is a place for support questions https://github.com/cssinjs/jss/discussions

I would use it as a dependency to ensure the version you use works with how you use it. Shouldn't be any conflict with user dependency.