search

cssinjs / jss

JSS is an authoring tool for CSS which uses JavaScript as a host language.
https://cssinjs.org
MIT License
7.08k stars 399 forks source link

JssProvider: convert class component to function component #1513

Closed behnammodi closed 3 years ago

behnammodi commented 3 years ago

All local test passed All flow check passed

https://github.com/cssinjs/jss/issues/1506

kof commented 3 years ago

I think we can merge it. I wouldn't merge the use "any" like that, but since we are migrating to typescript, these internal things won't be important anyways.

behnammodi commented 3 years ago

@kof Exactly, also currently we have a lot of any types, so we need a new PR to remove these. so, please merge this

behnammodi commented 3 years ago

@kof Also, I didn't use any type in this PR

kof commented 3 years ago

sorry, I ment the other PR https://github.com/cssinjs/jss/pull/1508 but both of them seem ready, ideally a pair more eyes on them and we should release as a patch version I think both of them. If they cause problems we would have to revert quickly and release another patch version and then iterate.

behnammodi commented 3 years ago

sorry, I ment the other PR #1508 but both of them seem ready, ideally a pair more eyes on them and we should release as a patch version I think both of them. If they cause problems we would have to revert quickly and release another patch version and then iterate.

Ok, also I tested both of them in a huge project everything is ok.

behnammodi commented 3 years ago

Please don't forget, we need to update PR https://github.com/cssinjs/jss/pull/1508 by https://github.com/cssinjs/jss/pull/1507

kof commented 3 years ago

merged 🎉

kof commented 3 years ago

Thank you!

kof commented 3 years ago

released in https://github.com/cssinjs/jss/releases/tag/v10.7.0