fix memory leak in dynamic nested rule

[seiyab]

Corresponding Issue(s):

1360

What Would You Like to Add/Fix?

Fix memory leak in nested rule in function rule

Todo

• [x] Add test(s) that verify the modified behavior
• [ ] Add documentation if it changes public API

Expectations on Changes

Resolve memory leak nested rule in function rule

// e.g.
{
  a: ({ color }) => {
    '& button': {
      color
    }
  }
}

Changelog

Fix memory leak with dynamic nested style.

Note

• For nested-conditional style, I have not changed.
  • Because change might be too big, and it might hold another problem.
  • I would tackle this on another PR.
• The test for memory leak is 24871d1 . Cherry-picking, you can verify that it works.
• I added some tests that are not irrelevant to memory leak to be sure that it doesn't break existing features.

[kof]

Wow this looks great!

I am going to investigate every change to see if everything is correct. The only thing that I don't like so far is the increase in bundle size. I have to think if we can achieve the same thing without adding that much logic.

[seiyab]

Thank you for your comment. I reduced bundle size a bit in 50b7b9b . I removed upsertRule and current replaceRule works like upsert.

[seiyab]

Thank you for your careful review 👍 I'll reply or fix each comment.

[seiyab]

For each comment, I fixed or replied.

[kof]

merged, thanks a lot, this is a huge help!

[kof]

released in https://github.com/cssinjs/jss/releases/tag/v10.8.1