1207 - update stylesheet if !important is set

cssinjs / jss

JSS is an authoring tool for CSS which uses JavaScript as a host language.

https://cssinjs.org

MIT License

7.08k stars 399 forks source link

1207 - update stylesheet if !important is set #1612

Closed behnammodi closed 2 years ago

behnammodi commented 2 years ago

Corresponding Issue(s): https://github.com/cssinjs/jss/issues/1207

What Would You Like to Add/Fix?

Update stylesheet if !important flag is set before and after the update

Todo

All tests passed
It wasn't a public API

Changelog

A issue is about when you want to update a CSS rule value with a !important flag

kof commented 2 years ago

Can you add a test please?

behnammodi commented 2 years ago

Sure, please tell me what kind of test do you mean?

kof commented 2 years ago

since this bug is in dom renderer, it will need a functional test that reads the applied css from the dom, some examples https://github.com/cssinjs/jss/blob/master/packages/jss/tests/functional/sheet.js#L548

behnammodi commented 2 years ago

since this bug is in dom renderer, it will need a functional test that reads the applied css from the dom, some examples https://github.com/cssinjs/jss/blob/master/packages/jss/tests/functional/sheet.js#L548

Great, I'm on it

behnammodi commented 2 years ago

@kof Done

kof commented 2 years ago

merged 🎉

kof commented 2 years ago

released https://github.com/cssinjs/jss/releases/tag/v10.9.1-alpha.2