search

csstools / postcss-language

Support for modern and experimental CSS within Visual Studio Code
80 stars 11 forks source link

fix: repository url #4

Closed herrboyer closed 4 years ago

herrboyer commented 4 years ago

Hi,

I'm trying to add postcss-language to VSX but it fails due to an invalid repository value in package.json, this should fix it.

Thanks

marcofugaro commented 4 years ago

This looks like an issue with the repo parser, not with this repo.

The short syntax is still valid syntax.

https://docs.npmjs.com/files/package.json#repository

herrboyer commented 4 years ago

Thanks @marcofugaro, I'm closing this MR to see what should be done on ovsx's side.

jonathantneal commented 4 years ago

I’m glad you created this PR, and I’d like to change the URL. It has sort of bothered me that csstools/postcss-language does not specify the service. I see that github:csstools/postcss-language is an option, but I like the full object even better because it supports subdirectories, which are useful in monorepos.

herrboyer commented 4 years ago

OK, reopening then :-)

jonathantneal commented 4 years ago

Thank you, @herrboyer. Will I also need to publish an update for this to the VSCode Marketplace?

herrboyer commented 4 years ago

You're welcome @jonathantneal !

Will I also need to publish an update for this to the VSCode Marketplace?

I don't think so, looks like the VSCode Marketplace (from Microsoft) had no problem fetching your project, but the Open VSX one (from the Eclipse foundation) had. I'll keep an eye on https://github.com/open-vsx/publish-extensions/actions and let you know if this fixed the pipeline for postcss-language.

herrboyer commented 4 years ago

It worked https://open-vsx.org/extension/csstools/postcss :tada: