search

cstb / citygml-energy

CityGML Energy ADE
40 stars 9 forks source link

Occupancy Module: about class type of Facilities #132

Closed gioagu closed 6 years ago

gioagu commented 7 years ago

Hello!

This is, as a matter of fact, a direct continuation of the previous issue regarding the EnergySystem. Piergiorgio and I were wondering whether it coule make sense to derive the class Facilities directly from _CityObject, similarly to the UsageZone and the BuildingUnit.

Or, on the other hand, why where they defined as Features (as they are now) and not as CityObjects?

What do you think?

g & pg

gioagu commented 7 years ago

Please refer to Issue 131 for the same reasons.

JoachimBenner commented 7 years ago

Proposal for version 0.9.0:

Derive the FeatureTypes Facilities, Occupants and Household from _CityObject

RomainNouvel commented 7 years ago

ok

gioagu commented 7 years ago

hi,

actually, I agree for facilities being derived from _CityObject, but not for Occupants and Households, as they refer (in my understanding) to people. See beginning of this ticket and link to ticket 131.

JoachimBenner commented 7 years ago

Can we agree on this change for version 0.9.0:

The FeatureType Facilities is derived from _CityObject?

gioagu commented 7 years ago

yes, agree!