cstb / citygml-energy

CityGML Energy ADE
43 stars 9 forks source link

Contruction and material names #57

Closed RomainNouvel closed 8 years ago

RomainNouvel commented 9 years ago

Presently, for the identification and management of the Construction objects, no name / description exist.

Concerning the Material, What contains precisely the attribute referenceURI? Can we get the material name through it? or it is just an reference id?

pgcipriano commented 9 years ago

In INSPIRE Buildings Data Specs (http://inspire.ec.europa.eu/documents/Data_Specifications/INSPIRE_DataSpecification_BU_v3.0.pdf, p.82) there are the following codelists:

Since some values are included in more than one codelist, it would be better to group them together in a unique one.

Maybe, the ReferenceURI could be something like this (example): <namespace:material xlink:href="http://someregistry.org/codelist/MaterialValue/wood/wood.en.xml"

RomainNouvel commented 9 years ago

Karl-Heinz, Joachim, I think you've included this attribute ReferenceURI in _AbstractMaterial. Does this attribute relate to existing references (kind of universal material database) here? If so, which one? Could you document it please?

JoachimBenner commented 9 years ago

Yes, we included this attribute, because gbXML also has such an attribute and it makes sense to optionally reference external sources containing additional material information. Of course, we do not have a specific database or external ressource in mind, why should a standard restrict this?

In principle, we do not need this attribute. _AbstractMaterial inherits all attributes and relations from _CityObject, and among these there is the relation "externalReference", pointing to the ExternalReference data type. This data type enables the specification of internet links, database connections, web services etc. I therefore propose to eliminate this attribute.

The same is true for the requested attributes "name" and "description" of a material. Any GML feature inherits these attributes from gml:AbstractFeature.

RomainNouvel commented 9 years ago
JoachimBenner commented 9 years ago
RomainNouvel commented 9 years ago

ok, then we don't need any further attribute. Joachim, if you think that a "referenceURI" in "Abstractmaterial" do not need to be explicitly mentioned, feel free to delete it. I don't have a specific opinion on this case.

JoachimBenner commented 9 years ago

ok,I propose to integrate this small change into #38