search

cstb / citygml-energy

CityGML Energy ADE
43 stars 9 forks source link

Rename relations *usageZones* and *thermalZones* #94

Closed JoachimBenner closed 8 years ago

JoachimBenner commented 8 years ago

In the CityGML standard as well as in the EnergyADE, most relation names are stated in singular. This has a good reason, because in the XML encoding the relation property either points to (via xlink:href) or imbeds exactly one related XML-element. Thus, the new relation thermalZones (_AbstractBuilding --> ThermalZone) must be instanciated once for every ThermalZone of the building, and the plural usage in the relation name is misleading and inconsistant with the rest of the data model. The same situation occurs with the relation usageZones (_AbstractBuilding --> UsageZone).

Proposal:

  1. Rename thermalZones --> thermalZone
  2. Rename usageZones --> usageZone
RomainNouvel commented 8 years ago

Hi Joachim, Then, the relationship holds the name of the object (without upper case). is that the standard way to proceed in XML Schema? If so, why is not not done for all relationships?

JoachimBenner commented 8 years ago

No, sometimes the XML-element names (with lower case starting character) are used as property names, but not always. My point is simply that it is confusing to write "thermalZones", followed by only one ThermalZone object.

gioagu commented 8 years ago

Agree with renaming.

bahujean commented 8 years ago

I agree with renaming (without "s" nor any upper case).

1- Rename thermalZones --> thermalZone 2- Rename usageZones --> usageZone

oliviertournaire commented 8 years ago

Implemented in latest version of the UML model