search

cta-wave / Test-Content-Generation

Provides all information and scripts how the CTA Wave Test Content is generated
BSD 3-Clause "New" or "Revised" License
4 stars 6 forks source link

database.json update process #45

Closed yanj-github closed 11 months ago

yanj-github commented 2 years ago

On the each run the script regenerates databse.json. Instead, can it just update the part that is new or replace what only what is updated please? The databse.json will have dolby contnet information it might get replaced after new content get generated.

rbouqueau commented 2 years ago

Instead, can it just update the part that is new or replace what only what is updated please?

It could. Just open an existing database and rewrite the section.

The databse.json will have dolby contnet information it might get replaced after new content get generated.

Yes, people need to submit PR to merge their database.json content with the existing one. I think generating the PR is fairly easy, I don't know how much of a good job Github makes when updating full sections of the JSON (for the reviewer).

gitwjr commented 1 year ago

2022-06-12 meeting: Peter will review with Yan. Yan will add comment after she reviews the issue and the associated process.

yanj-github commented 1 year ago

Changes to the database.json should be carefully managed. We agree with suggested process that people need to submit PR to merge their database.json content with the existing one. And the PR has to be reviewed and merged by a reviewer.

jpiesing commented 11 months ago

@yanj-github Are we going to do any more on this or can we close it?

yanj-github commented 11 months ago

I am happy to close this issue. The process is agreed merging instead of overwritting.