search

cta-wave / device-observation-framework

This repository contains the WAVE Device Observation Framework. The DPCTF Device Observation Framework determines pass or fail results, based on observations taken of tests which are run on a device by the DPCTF Test Runner. DPCTF is the Device Playback Compatibility Task Force of the CTA WAVE Project (https://CTA.tech/WAVE and standards@CTA.tech for more info).
Other
1 stars 3 forks source link

enable more recent version of python with the OF #59

Closed jpiesing closed 1 month ago

jpiesing commented 1 year ago

The instructions for the OF state the following.

Note: If your system uses python version 3.10 or greater you will have to downgrade to one of the supported versions mentioned above. Some of the python packages required by the observation framework are not supported in python version 3.10 or greater.

In the medium term, this needs to be addressed. The OF should not require python packages that are not supported in the future.

Note that Ubuntu Jammy (22.04) includes python version 3.10 so requires a downgrade.

Forked from https://github.com/cta-wave/device-observation-framework/issues/58

yanj-github commented 1 year ago

We have fixed OpenCV version because OpenCV library is linked directly to the observation result. Specified OpenCV version at the moment is not supported to more recent version of python. Therefore, OpenCV has to be upgraded and fix to more recently version. This has to be tested and carefully done to make sure new library and python versions fully supported.

jpiesing commented 1 year ago

We have fixed OpenCV version because OpenCV library is linked directly to the observation result. Specified OpenCV version at the moment is not supported to more recent version of python. Therefore, OpenCV has to be upgraded and fix to more recently version. This has to be tested and carefully done to make sure new library and python versions fully supported.

Which is why I applied the "deferred" label at the same time as filing the issue :)

yanj-github commented 6 months ago

We have tested OpenCV v4.9.0.80 with Python v3.10.12 the new library and python versions are fully supported.

We also have compared observation results with OpenCV version OpenCV v4.9.0.80 (new) and OpenCV v4.5.2.52 (current), and noticed that the results are mostly same, except, the tests that contains low resolution contents such and switching set tests QR code.

e.g: cfhd_12.5_25_50-local-fullscreen-playback-of-switching-sets_ss1-2_debug and cfhd_12.5_25_50-local-overlapping-fragments_ss1_debug tests took from Plugfest 2024 on TV2.

The plugfest tests were taken in normal office environment not in controlled dark room. Recording taken carefully in controlled environment might not cause differences to the test results.

yanj-github commented 3 months ago

Package numpy is installed by matplotlib that we used to plot image for helping audio debugging. numpy 2 is out now which was not compatible with opencv. The compatibility issue is fixed on opencv version 4.10.0.84 We will consider to use opencv version 4.10.0.84 onwards.

yanj-github commented 3 months ago

Current latest version to date numpy 2.1.0 has a bug in reshaping function. We use this feature for audio processing using this specific version wont work with audio observation. We are looking to fix numpy package version on the set up script.

yanj-github commented 2 months ago

Changes made to the master please feel free to close the issue when you happy.