search

cta-wave / device-observation-framework

This repository contains the WAVE Device Observation Framework. The DPCTF Device Observation Framework determines pass or fail results, based on observations taken of tests which are run on a device by the DPCTF Test Runner. DPCTF is the Device Playback Compatibility Task Force of the CTA WAVE Project (https://CTA.tech/WAVE and standards@CTA.tech for more info).
Other
1 stars 3 forks source link

possible error calculating expected last frame on spicing tests #62

Closed jpiesing closed 1 year ago

jpiesing commented 1 year ago

With the Philips 20230714 recording, 4 splicing tests report an error of the form ..

[OF] Every sample S[k,s] shall be rendered and the samples shall be rendered in increasing presentation time order. FAIL Xx01: Last frame found is 250, expected to end at 288. Last frame number tolerance is 0. Mid frame number tolerance is 10. Following frames are missing: 25 41 85 Total of missing frames is 41.

The missing frames are due to the encoding issue with AD-A1 but the last frame found issue looks to me like a bug in the OF in calculating what last frame is expected.

Looking at the recording with a video editor, frame 250 is the standard red 'end of sequence' marker so frames 251 to 288 simply don't exist.

yanj-github commented 1 year ago

Configurations: "playout": [ [1, 1, 1], [1, 1, 2], [1, 1, 3],
[2, 1, 1], [2, 1, 2], [2, 1, 3], [1, 1, 4], [1, 1, 5], [1, 1, 6] ]

"fragment_duration": "PT0H0M1.920S" "frame_rate": "25"

Calculation: 1.92 6 = 11.52 25 = 288

I think this issue is caused by last fragment is shorter. And I think this issue is duplicated with what we have raised already https://github.com/cta-wave/device-observation-framework/issues/46 In progress and we are planning to include this for next release.

yanj-github commented 1 year ago

@jpiesing We have merged audio part in it should have addressed this issue please take a look.

gitwjr commented 1 year ago

Closed. Handled in #46 which is closed.