search

cta-wave / dpctf-tests

Repo for DPCTF Tests. We prefer to keep the Tests separated from Test Runner
Other
1 stars 5 forks source link

configuration playout is missing for test playback-over-wave-baseline-splice ... ... at13_at14.html #115

Closed yanj-github closed 9 months ago

yanj-github commented 10 months ago

playout parameter is missing for the splice test. At the moment it only plays main not there is no ad.

FritzHeiden commented 10 months ago

Thank you for reporting, I pushed a fix. Please check again

yanj-github commented 10 months ago

We are testing it now. Will confirm it soon. While testing we found another issue on test playback-over-wave-baseline-splice-constraints this test is a section 8 test we dont need audio linked with video. It should contain only video.

FritzHeiden commented 10 months ago

While testing we found another issue on test playback-over-wave-baseline-splice-constraints this test is a section 8 test we dont need audio linked with video. It should contain only video.

I removed audio from this test

yanj-github commented 10 months ago

Thanks @FritzHeiden I have checked the tests.json which looks good to me. I just noticed that removing audio changes the test code, and I think you forgot to change the matching playout in test-config.json file. playback-over-wave-baseline-splice-constraints__splice_main_spliceadat13_at14.html to playback-over-wave-baseline-splice-constraints__splice_main_splice_ad.html

FritzHeiden commented 9 months ago

Thanks, I pushed a fix for this.

yanj-github commented 9 months ago

LGTM