search

cta-wave / dpctf-tests

Repo for DPCTF Tests. We prefer to keep the Tests separated from Test Runner
Other
2 stars 5 forks source link

Regenerated Dolby tests to fix audio content issue. #131

Closed yanj-github closed 12 months ago

yanj-github commented 1 year ago

@FritzHeiden can you help review and merge when you are happy with this please?

FritzHeiden commented 12 months ago

@yanj-github can you please regenerate the tests from your tests.csv to resolve conflicts

yanj-github commented 12 months ago

@FritzHeiden I don't have write permission to merge and modify the pull request will you be able to help just merge the tests.csv please? Then I will get test generation changes in another pull request.

louaybassbouss commented 12 months ago

@yanj-github I see there are conflicts. @FritzHeiden fixed bugs in last few days, can you generate the tests again using last updates in the master and create a new pull request? I think this will be the safest way to avoid using different versions of library files in generated files. We can then quickly merge the PR.

yanj-github commented 12 months ago

@yanj-github I see there are conflicts. @FritzHeiden fixed bugs in last few days, can you generate the tests again using last updates in the master and create a new pull request? I think this will be the safest way to avoid using different versions of library files in generated files. We can then quickly merge the PR.

Yes I can regenerate test in another pull request. But if I do sync up on my forked repo I will have to drop the last commit which I will loose the tests.csv file as well. Will you be able to just get one tests.csv file merged then I will regenerates tests again.