Closed jasperf closed 3 years ago
can u repro with the demo repo ?
@ctf0 Only tested in our application. Any recommendation do do a quick demo setup? Should I just set up Laravel 8 and then add the package? I checked https://github.com/ctf0/Laravel-Media-Manager/wiki and did not see a reference on setting up a demo or testing package. Basic installation like https://github.com/ctf0/Laravel-Media-Manager#installation there is of course.. but that is not all that would be needed.
ur issue is with https://github.com/ctf0/Laravel-Media-Manager/blob/master/src/resources/assets/js/components/search-by-voice.vue
am not sure how come u r getting the can't access property "abort"
error where the btn it self is not rendered , but still i've updated the file, plz manually test it with your setup and reply back
Did test with the change you added, but still had the same error Speech Recognition is not supported using:
stop() {
this.run = false
annyang?.abort()
},
start() {
this.run = true
annyang?.start()
Also had Parsing error: Unexpected token .
eslint on first added ?
to abort section.
Perhaps it is just the way it is because there is no support by my Firefox Developer browser or MacMini..? I do however have in earphones with microphone working..
looking into https://github.com/TalAter/annyang some as well.
Checked https://stackoverflow.com/questions/39784986/speechrecognition-is-not-working-in-firefox and realized I had to turn it on:
_To enable the SpeechRecognition in Firefox Nightly > 72, go to about:config and switch the flags media.webspeech.recognition.enable
and media.webspeech.recognition.force_enable
to true
._
and then all was well. Microphone was then also loaded in modal.
glad u fixed it but can u plz undo the browser changes & retest with the new
and tell me if the error
Vue warn]: Error in callback for watcher "searchFor": "TypeError: can't access property "abort", annyangWEBPACK_IMPORTED_MODULE0default.a is null"
is gone ?
I tested once more running npm run dev
post restoring to older filer with just
stop() {
this.run = false
annyang.abort()
},
start() {
this.run = true
annyang.start()
and the warning also did not return. So with speech recognition enabled and enforced in Firefox Developer 87.0b7 (64-bit) the issue is no longer occurring. I then quickly tested in Chrome and all as well as well. Well, I had the issue in Firefox mainly but just wanted to see..
Update
Did see you version https://github.com/ctf0/Laravel-Media-Manager/commit/dfc198f8c92dcb363eb02f9cbbd57ca55bdd13fc had new checks for support
so I updated file again and rebuilt. Then I checked again. Again no errors. When I turned speech recognition off again and reload I also did not see errors. But will test again post Firefox Developer reload shortly.
Yeah, no errors post Firefox Developer reload with speech recognition turned off and with your latest patch. So I guess your latest patch works @ctf0 .
NB Added patch as new branch to our own repository. May do some additional testing.
perfect, thanks again.
Laravel version
php artisan -v
:Laravel Framework 8.24.0 Manager versioncomposer info ctf0/media-manager
:Related to usage
media manager error
and
as well as:
Not yet.