search

ctf0 / laravel-mix-versionhash

Auto append hash to file instead of using virtual one
MIT License
61 stars 18 forks source link

Hopefully solves issue #29 in source #37

Closed g-ackolad closed 4 years ago

g-ackolad commented 4 years ago

Got involved in a project that utilizes laravel-mix-versionhash and ran in to the issue of browserSync not starting. This change fixed the issue on my machine, so I decided to create a pull request.

Cheers!

ctf0 commented 4 years ago

thank you so much for this, can u plz walk me through what it does ?

g-ackolad commented 4 years ago

@ctf0 The problem, for me at least, was that I didn't get any options. So options.length was undefined. But there was no check to make sure that options was not undefined. This just checks that "this.options" are defined and if not, runs register() with default values.

ctf0 commented 4 years ago

perfect, but this doesnt solve the browsersync issue, right ?

g-ackolad commented 4 years ago

@ctf0 for me it did. I think the problem, for me at least, was that browserSync didn't start after I got this error.

ctf0 commented 4 years ago

perfect, thanx again.