search

ctftime / ctftime.org

meta repository for ctftime.org issues, feature-requests etc
69 stars 1 forks source link

Missing pagination - countries stats #407

Open mbiesiad opened 2 weeks ago

mbiesiad commented 2 weeks ago

Hi, In recent weeks there was some change which led to missing pagination (at least) - countries stats.

Repro steps:

Go to country stats, for example visit: https://ctftime.org/stats/PL or https://ctftime.org/stats/DE Scroll down - notice missing previously visible pagination.

Issue:

At this moment you can not see how many teams are in selected country (ie.: 2024 year).

Moreover, if we visit https://ctftime.org/stats/PL we can see 'Top 19' (Country position col.). While visiting https://ctftime.org/stats/DE we can see 'Top 25'.

For new users or visitors it can leads to misinformation, because visitors can think that selected country has only this teams number. Quick example: let's take a look at https://ctftime.org/stats/PL with "19 teams" at this moment. If we check how it looked like before, we can see 3 sites of pagination for this case - please notice that there was also 'Top 50 country teams' displayed (not '19' - for first pagination site). That means for this case there is no '19' teams, but over than '100'. Similar issue occurs with other countries now (as mentioned).

Additional informations:

'In recent weeks' - it looks like dates: 2024-07-08 or even 2024-08-05 that was fine, pagination was OK (at least for PL country stats) for example.

Current view: ctf1a

Previous view (pagination): ctf1ab

Best regards,

AlfredSimpson commented 1 week ago

Adding on to this - the count seems to be limited to the top 999 teams in the world. This explains why some countries have many showing and some have none.

image You'll see that in this screenshot I am on Page 20 - and can progress no further. We're looking at global teams in this view. It caps at 999. However, as @mbiesiad mentioned, there are significantly more teams in the world.

image

Not sure if the way team rankings show will fundamentally change or if something on the back-end has nuked it.

I do know that teams who are not in the top 999 in the world will be listed as tied for the next rank in their nation.

For example, in the United States we list 85 teams. Any team not in the top 999 in the world will show as tied for 86th, like so: image