search

ctimmerm / axios-mock-adapter

Axios adapter that allows to easily mock requests
MIT License
3.45k stars 244 forks source link

Test types #369

Closed remcohaszing closed 1 year ago

remcohaszing commented 1 year ago

Let’s make sure types are valid from now on. :)

Based on https://github.com/ctimmerm/axios-mock-adapter/pull/368

marcbachmann commented 1 year ago

There's also still https://github.com/ctimmerm/axios-mock-adapter/pull/356 open. Does that look good to merge? 😄 So I'd merge the other first, this then fails if it's not correct.

marcbachmann commented 1 year ago

Looks like type testing works. 😁 😅 https://github.com/ctimmerm/axios-mock-adapter/commit/3ccceaf4f926900f86242efb514e320e0b2226fd broke it a bit. Should we revert it as AxiosStatic just extends AxiosInstance: https://github.com/axios/axios/blob/e7decef6a99f4627e27ed9ea5b00ce8e201c3841/index.d.ts#L523