search

ctmm-initiative / ctmmweb

Web app for analyzing animal tracking data, built upon ctmm R package
http://biology.umd.edu/movement.html
GNU General Public License v3.0
34 stars 22 forks source link

Select all after use of search #46

Closed vestlink closed 6 years ago

vestlink commented 6 years ago

When searching within loaded individuals, one should be able to select all individuals based on the search results.

xhdong-umd commented 6 years ago

If you filtered the individuals by inputing in the search field, the app will update to the filtered results, which is just like all results have been selected.

The only difference is that if the results is more than 1 page and only current page is shown. But you can change the page length to up to 20.

Or is there anything you think not covered yet with this?

vestlink commented 6 years ago

I see. It was more of a Nice to have feature when you have e.g. individuals in your data set.

On 22 Jan 2018 15:55, "xianghui dong" notifications@github.com wrote:

If you filtered the individuals by inputing in the search field, the app will update to the filtered results, which is just like all results have been selected.

The only difference is that if the results is more than 1 page and only current page is shown. But you can change the page length to up to 20.

To make the select all button work with search result is doable, I just think the current behavior worked for the purpose already.

Or is there anything you think not covered yet with this?

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/ctmm-initiative/ctmmweb/issues/46#issuecomment-359446974, or mute the thread https://github.com/notifications/unsubscribe-auth/AT0_HKp3w4mBg-GYaVM-RWF2ZZvYpHTdks5tNKFegaJpZM4Rl2b4 .

xhdong-umd commented 6 years ago

I'm a little confused. If you input some words in the search field, the table will be updated with rows that match the words.

Does select all individuals based on the search results mean to select all rows that match the words?

What is the difference from the current behavior? The rows are not highlighted but they are "current page" so the app actually updated to reflect them.

vestlink commented 6 years ago

I see what you mean.

The functionality of the app is correct.

It's just from a users point of view and the logic of the app.

It might just be me, but when i search for something I maybe wan't to eventually select the search result as a whole.

But the app in itself behaves nicely.

xhdong-umd commented 6 years ago

Yes, the app actually take current page as "selected" if no rows are explicitly selected. This is mentioned in help but may not be obvious to users.

I realized that could be one scenario an explicitly selection is useful: user can filter the individuals, select them with the button, then clear the filter and still keep the selection. Now it's easy to see which are selected and which are not. The dynamic filtering works great for fast checking, but it will become lost after the filter is cleared.

I have updated the app so that select all button work on filtered rows.