search

cubiq / ComfyUI_essentials

MIT License
508 stars 60 forks source link

[FEATURE REQUEST] Allow multiple generations if using "?" random seed on FluxSamplerParams+ Node #76

Open gonzalu opened 3 weeks ago

gonzalu commented 3 weeks ago

Hi Matteo,

Right now your wonderful FluxSamplerParams+ node is not generating new seeds/generations if nothing chanegs between Queued generations.

Say:

--Prompt is the same and all other settings identical --add 25 to the Queue --Seed is set to "?"

Comfy just saves the initial generation 25 times. I expected the seed to change between generations.

Is this possible?

Thanks.

image

cubiq commented 3 weeks ago

fair enough

gonzalu commented 3 weeks ago

You are AWESOME!!

Thanks Matteo

eiddor commented 3 weeks ago

This workaround works for now, though it adds about 100 seconds on my machine because it has to reload the models etc.

image

Our of pure curiosity and masochism, I'm trying to teach myself enough Python/coding/ComfyUI to try to figure this out on my own. It seems that ComfyUI is caching what we have in the node and not calling it on subsequent runs, even though we have that "?" random setting.

I'm trying to find out where that logic is handled in ComfyUI and how to trigger it to use our node each time if that value is set.

cubiq commented 3 weeks ago

doing that is more complicated than it seems unfortunately. I'll think of something, I believe I will add a ?? keyword that will force a new number.

zpengcom commented 3 weeks ago

doing that is more complicated than it seems unfortunately. I'll think of something, I believe I will add a ?? keyword that will force a new number.

Can support for lora be added? thx

gonzalu commented 3 weeks ago

doing that is more complicated than it seems unfortunately. I'll think of something, I believe I will add a ?? keyword that will force a new number.

Can support for lora be added? thx

I just use the rgthrees Lora Power Loader node which is FANTASTIC... allows you to turn on or off as many LoRAs as you want in the workflow.

image

zpengcom commented 1 week ago

doing that is more complicated than it seems unfortunately. I'll think of something, I believe I will add a ?? keyword that will force a new number.

Can support for lora be added? thx

I just use the rgthrees Lora Power Loader node which is FANTASTIC... allows you to turn on or off as many LoRAs as you want in the workflow.

image

I mean to output grid graphs of different lora intensities