search

cucumber / polyglot-release

Make polyglot releases with a single command
MIT License
5 stars 1 forks source link

Bad regexp for semver #72

Closed aslakhellesoy closed 2 years ago

aslakhellesoy commented 2 years ago

https://github.com/cucumber/polyglot-release/blob/bef650062f56b72d9d8f0243f38eb41126c1c33b/polyglot-release#L206

The dots must be escaped with \..

mattwynne commented 2 years ago

What you say makes sense, but when I try to test it, it seems to work as I'd expect.

e.g.

./polyglot-release-test ./tests/fixtures/polyglot
testing the tests ✅
You are in a manual test sandbox. You can safely git push and commits will be pushed to the repo in ../origin
bash-3.2$ polyglot-release
Please specify a version to release. Use --help to show usage instructions.

To help you choose the next version, here are the unreleased changes:

### Fixed
- This is a test

bash-3.2$ polyglot-release 12.1
Invalid MAJOR.MINOR.PATCH argument: 12.1
Usage: polyglot-release [OPTIONS] MAJOR.MINOR.PATCH
OPTIONS:
  --help                 shows this help
  --update               updates this script to the latest version
  --version              show the current version
  --no-git-push          do not push to git
  --quiet                don't log progress messages
bash-3.2$ polyglot-release 1
Invalid MAJOR.MINOR.PATCH argument: 1
Usage: polyglot-release [OPTIONS] MAJOR.MINOR.PATCH
OPTIONS:
  --help                 shows this help
  --update               updates this script to the latest version
  --version              show the current version
  --no-git-push          do not push to git
  --quiet                don't log progress messages
bash-3.2$ polyglot-release 1.2.x
Invalid MAJOR.MINOR.PATCH argument: 1.2.x
Usage: polyglot-release [OPTIONS] MAJOR.MINOR.PATCH
OPTIONS:
  --help                 shows this help
  --update               updates this script to the latest version
  --version              show the current version
  --no-git-push          do not push to git
  --quiet                don't log progress messages
bash-3.2$ polyglot-release 1.2.6 --quiet
release/v1.2.6

Do you have a specific example of a NEW_VERSION string you can pass that doesn't work?

aslakhellesoy commented 2 years ago

@mattwynne I didn’t say it doesn’t work. It was just too permissive. @mpkorstanje fixed it.