cucumber / polyglot-release

Make polyglot releases with a single command
MIT License
5 stars 1 forks source link

Fixes for MacOS. Add MacOS to CI matrix. #74

Closed aslakhellesoy closed 2 years ago

aslakhellesoy commented 2 years ago

🤔 What's changed?

The polyglot-release script has been modified to be portable between Linux and MacOS. In particular, sed -i is no longer used since it requires an argument on MacOS, but not on Linux.

Furthermore, the tag filtering has been refactored to filter with grep rather than relying on git ls-remote. The POLYGLOT_RELEASE_GIT_REPO now has a default value: git config --get remote.origin.url.

⚡️ What's your motivation?

Release from a mac, not having to specify POLYGLOT_RELEASE_GIT_REPO

🏷️ What kind of change is this?

📋 Checklist:


This text was originally generated from a template, then edited by hand. You can modify the template here.

aslakhellesoy commented 2 years ago

Any idea why the MacOS build might be failing? The tests pass fine on my mac.

mpkorstanje commented 2 years ago

I think:

Run ./polyglot-release-test
./polyglot-release-test: line 7: realpath: command not found